uncommented Test_getDomainAPI in utils_test.go

pkg/dns/utils_test.go

@@ -1,7 +1,9 @@
 package dns
 
 import (
+	"context"
 	"fmt"
+	"os"
 	"reflect"
 	"testing"
 
@@ -9,6 +11,8 @@ import (
 	//client "github.com/kubernetes-sdk-for-go-101/pkg/client"
 	v1 "k8s.io/api/core/v1"
 	extapi "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	testclient "k8s.io/client-go/kubernetes/fake"
 )
 
 func Test_loadConfig(t *testing.T) {
@@ -77,7 +81,6 @@ func Test_loadConfig(t *testing.T) {
 	}
 }
 
-/*
 func Test_getDomainAPI(t *testing.T) {
 	jsonBothKey := &extapi.JSON{
 		Raw: []byte(`{
@@ -155,39 +158,39 @@ func Test_getDomainAPI(t *testing.T) {
 			shouldErr: false,
 		},
 	}
-		for _, test := range testCases {
+	for _, test := range testCases {
-			fakeKubernetesClient := testclient.NewSimpleClientset()
+		fakeKubernetesClient := testclient.NewSimpleClientset()
-			pSolver := &main.LocalDNSProviderSolver{
+		pSolver := &LocalDNSProviderSolver{
-				client: fakeKubernetesClient,
+			client: fakeKubernetesClient,
-			}
-
-			if test.secret != nil {
-				_, err := pSolver.client.CoreV1().Secrets(test.ch.ResourceNamespace).Create(context.Background(), test.secret, metav1.CreateOptions{})
-				if err != nil {
-					t.Errorf("failed to create kubernetes secret")
-				}
-			}
-			for k, v := range test.env {
-				os.Setenv(k, v)
-			}
-			_, err := getDomainAPI(test.ch)
-			if err != nil {
-				if !test.shouldErr {
-					t.Errorf("got error %v where no error was expected", err)
-				}
-				if err.Error() != test.errMessage {
-					t.Errorf("expected error %s, got %s", test.errMessage, err.Error())
-				}
-			} else if test.shouldErr {
-				t.Errorf("didn't get an error where an error was expected with message %s", test.errMessage)
-			}
-			for k := range test.env {
-				os.Unsetenv(k)
-			}
 		}
 
+		if test.secret != nil {
+			_, err := pSolver.client.CoreV1().Secrets(test.ch.ResourceNamespace).Create(context.Background(), test.secret, metav1.CreateOptions{})
+			if err != nil {
+				t.Errorf("failed to create kubernetes secret")
+			}
+		}
+		for k, v := range test.env {
+			os.Setenv(k, v)
+		}
+		_, err := getDomainAPI(test.ch)
+		if err != nil {
+			if !test.shouldErr {
+				t.Errorf("got error %v where no error was expected", err)
+			}
+			if err.Error() != test.errMessage {
+				t.Errorf("expected error %s, got %s", test.errMessage, err.Error())
+			}
+		} else if test.shouldErr {
+			t.Errorf("didn't get an error where an error was expected with message %s", test.errMessage)
+		}
+		for k := range test.env {
+			os.Unsetenv(k)
+		}
+	}
+
 }
-*/
+
 // dummy, should actually return the API, but here we just return the config
 func getDomainAPI(ch *v1alpha1.ChallengeRequest) (*LocalDNSProviderConfig, error) {
 	config, err := LoadConfig(ch.Config)